]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appDisplay: Fix off-by-one when incrementally adding application icons
authorOwen W. Taylor <otaylor@fishsoup.net>
Wed, 27 Apr 2011 11:50:10 +0000 (07:50 -0400)
committerColin Walters <walters@verbum.org>
Tue, 3 May 2011 12:52:39 +0000 (08:52 -0400)
A "cosmetic" code arrangement I requested in code review resulted
in one too few items being removed from the queue for each incremental
chunk of icons added. Fix.

https://bugzilla.gnome.org/show_bug.cgi?id=648739

js/ui/appDisplay.js

index 1dabc2cd58bcbdee1344407956787200444fe53e..050432134fe6c9cfbdb8b844bc1b14b60bc20c7c 100644 (file)
@@ -126,7 +126,7 @@ AlphabeticalView.prototype = {
             if (currentTimeMillis - startTimeMillis > MAX_APPLICATION_WORK_MILLIS)
                 break;
         }
-        this._pendingAppIds.splice(0, i);
+        this._pendingAppIds.splice(0, i + 1);
         if (this._pendingAppIds.length > 0) {
             return true;
         } else {